Remove test fixture compileAndRunScript and compileAndInstantiateModule #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The utility method is unused other than to test itself. Removing this removes a number of direct uses of v8 apis in the code that just appear to be unnecessary.
ohodson
approved these changes
Sep 28, 2023
mikea
approved these changes
Sep 28, 2023
jasnell
deleted the
jsnell/remove-unused-testfixture-compileandrunscript
branch
|
ah well, I accidentally landed with squash and merge combining the two commits. Doh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utility methods are unused in workerd other than to test themselves.
Removing this removes a number of direct uses of v8 apis in the code that just appear to be unnecessary.
In the internal equivalent the
compileAndRunScriptutility is also unused and can safely be removed.An argument can be made to keep
compileAndInstantiateModulesince internally that is used in a handful of fuzzing tests but it's not clear if those will ever be ported out to workerd and the internaltest-fixtureimpl has it's own copy ofcompileAndInstantiateModule. Removing this in a separate commit here so that, if necessary, we can revert removingcompileAndInstantiateModuleseparately if necessary.